Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
joaopedrodcf
left a comment
There was a problem hiding this comment.
Hope you guys don't mind me trying to review the PR 🙏
| try { | ||
| const replacement = await $fetch<ModuleReplacement | null>(`/api/replacements/${name}`) | ||
| const response = await $fetch<{ | ||
| mapping: ModuleReplacementMapping |
There was a problem hiding this comment.
@danielroe iirc you said these types are inferred based on the route. is that true? does this not infer them because of the interpolation?
|
Are we deferring this till 0.9? |
|
yes. it relies on me publishing module-replacements@3 too, which I haven't done yet. |
|
I'll also start on working adding replacements v3 to https://github.com/npmx-dev/vscode-npmx 👍 |
|
does this close #1976? |
No, will be a separate PR for that |
Module replacements v3
Description
Update
module-replacementsto v3Update
Compare/ReplacementSuggestion.vue,Package/Replacement.vue,npm/useReplacementDependencies.ts,useCompareReplacements.ts,useModuleReplacement.ts,package/[[org]]/[name].vue,replacements/[...pkg].get.tsaccordinglyRemove
"MDN"from localesUpdate existing tests:
a11y.spec.ts,composables/use-replacement-dependencies.spec.ts,composables/use-compare-replacements.spec.tsAdd new test fixture
npm-registry/packuments/strip-ansi.jsonAdd new tests:
e2e/compare-replacements.spec.ts,e2e/package-replacements.spec.tsScreenshots
Simple
Native
Documented
Removal
Compare page